mentos1386/send
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix download count on server (#863)

Browse source
This commit is contained in:
Emily Hou 2018-07-17 09:48:47 -07:00 committed by GitHub
parent d906e927ed
commit 59ba89262f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/api.js
View file

@ -169,7 +169,6 @@ function download(id, keychain, onprogress, canceller) {
const auth = await keychain.authHeader();
xhr.open('get', `/api/download/${id}`);
xhr.setRequestHeader('Authorization', auth);
xhr.setRequestHeader('Connection', 'close');
xhr.responseType = 'blob';
xhr.send();
onprogress([0, 1]);

3
server/routes/download.js
View file

@ -21,10 +21,11 @@ module.exports = async function(req, res) {
file_stream.destroy();
});
file_stream.on('close', async () => {
file_stream.on('end', async () => {
if (cancelled) {
return;
}
const dl = meta.dl + 1;
const dlimit = meta.dlimit;
try {

18
test/frontend/tests/workflow-tests.js
View file

@ -134,7 +134,23 @@ describe('Upload / Download flow', function() {
}
});
it('can cancel and not increase download count', async function() {
it('can increase download count on download', async function() {
const fs = new FileSender(blob);
const file = await fs.upload();
const fr = new FileReceiver({
secretKey: file.toJSON().secretKey,
id: file.id,
nonce: file.keychain.nonce,
requiresPassword: false
});
await fr.getMetadata();
await fr.download(noSave);
await file.updateDownloadCount();
assert.equal(file.dtotal, 1);
});
it('does not increase download count when download cancelled', async function() {
const fs = new FileSender(blob);
const file = await fs.upload();
const fr = new FileReceiver({