mirrors-yuzu-emu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad synced 2024-11-26 01:17:46 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix for non-constant SIGSTKSZ

Browse source 
On glibc > 2.33, `SIGSTKSZ` might not be constant (in which case
it expands to a call to `sysconf` which returns a `long int`); see
https://sourceware.org/pipermail/libc-alpha/2020-October/118513.html

Pass unsigned explicitly to std::max, to avoid relying on template
argument deduction. This works both with the old-style constant
`SIGSTKSZ` and the new configurable one.

Initially based on https://chromium-review.googlesource.com/c/2776379

Change-Id: I9fc95337f973e871b84735ce822b5e11ba73ea8c
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3340721
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
David Faure 2021-12-15 22:26:40 +01:00 committed by Mark Mentovai
parent 3846f6d297
commit 605c51ed96
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/client/linux/handler/exception_handler.cc
View file

@ -138,7 +138,7 @@ void InstallAlternateStackLocked() {
// SIGSTKSZ may be too small to prevent the signal handlers from overrunning // SIGSTKSZ may be too small to prevent the signal handlers from overrunning
// the alternative stack. Ensure that the size of the alternative stack is // the alternative stack. Ensure that the size of the alternative stack is
// large enough. // large enough.
static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ); const unsigned kSigStackSize = std::max<unsigned>(16384, SIGSTKSZ);
// Only set an alternative stack if there isn't already one, or if the current // Only set an alternative stack if there isn't already one, or if the current
// one is too small. // one is too small.