mirrors-yuzu-emu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad synced 2024-11-23 08:54:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

README: update dev documents w/new git flow

Browse source 
BUG=chromium:502355
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1335483002 .
This commit is contained in:
Mike Frysinger 2015-09-11 01:38:20 -04:00
parent e8dbddf291
commit a057bc5d3e
1 changed files with 13 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
README
View file

@ -14,30 +14,24 @@ If you need to reconfigure your build be sure to run "make distclean" first.
----- -----
To request change review: To request change review:
0. Get access to a read-write copy of source. 0. Get a copy of depot_tools repo.
Owners at http://code.google.com/p/google-breakpad/ are able to grant http://dev.chromium.org/developers/how-tos/install-depot-tools
this access.
1. Check out a read-write copy of source using instructions at 1. Create a new directory for checking out the source code.
http://code.google.com/p/google-breakpad/source/checkout mkdir breakpad && cd breakpad
2. Make changes. Build and test your changes. 2. Run the `fetch` tool from depot_tools to download all the source repos.
fetch breakpad
3. Make changes. Build and test your changes.
For core code like processor use methods above. For core code like processor use methods above.
For linux/mac/windows, there are test targets in each project file. For linux/mac/windows, there are test targets in each project file.
3. Download http://codereview.appspot.com/static/upload.py 4. Commit your changes to your local repo and upload them to the server.
http://dev.chromium.org/developers/contributing-code
4. Run upload.py from the 'src' directory: e.g. git commit ... && git cl upload ...
upload.py --server=codereview.chromium.org
You will be prompted for credential and a description. You will be prompted for credential and a description.
5. At http://breakpad.appspot.com you'll find your issue listed; click on it, 5. At https://codereview.chromium.org/ you'll find your issue listed; click on
and select Publish+Mail, and enter in the code reviewer and CC it, and select Publish+Mail, and enter in the code reviewer and CC
google-breakpad-dev@googlegroups.com google-breakpad-dev@googlegroups.com
6. When applying code review feedback, specify the '-i' option when running
upload.py again and pass the issue number so it updates the existing issue,
rather than creating a new one.
Be sure to rerun upload.py from the same directory as you did for previous
uploads to allow for proper diff calculations.