From ad8a43f367e7f131f0306540a6f88db4d4c9c906 Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Fri, 24 Jun 2022 12:19:32 -0700 Subject: [PATCH] dwarf_cu_to_module_unittest: fix tests https://crrev.com/7933ec0a69bac134b7cee4b60a5dc80743b2b1a9 removed warnings about unknown abstract origins, which caused these tests to fail on ChromeOS. Update these tests to reflect the code changes in said CL. Bug: b:235999011 Change-Id: Ifa450d33080d955d33b3aadb951c2e75c0aa1c85 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3723686 Reviewed-by: Mike Frysinger --- src/common/dwarf_cu_to_module_unittest.cc | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/common/dwarf_cu_to_module_unittest.cc b/src/common/dwarf_cu_to_module_unittest.cc index 499ec49b..cbe317f9 100644 --- a/src/common/dwarf_cu_to_module_unittest.cc +++ b/src/common/dwarf_cu_to_module_unittest.cc @@ -781,9 +781,6 @@ TEST_F(SimpleCU, AbstractOriginNotInlined) { } TEST_F(SimpleCU, UnknownAbstractOrigin) { - EXPECT_CALL(reporter_, UnknownAbstractOrigin(_, 1ULL)).WillOnce(Return()); - EXPECT_CALL(reporter_, UnnamedFunction(0x11c70f94c6e87ccdLL)) - .WillOnce(Return()); PushLine(0x1758a0f941b71efbULL, 0x1cf154f1f545e146ULL, "line-file", 75173118); StartCU(); @@ -799,8 +796,6 @@ TEST_F(SimpleCU, UnknownAbstractOrigin) { } TEST_F(SimpleCU, UnnamedFunction) { - EXPECT_CALL(reporter_, UnnamedFunction(0xe34797c7e68590a8LL)) - .WillOnce(Return()); PushLine(0x72b80e41a0ac1d40ULL, 0x537174f231ee181cULL, "line-file", 14044850); StartCU(); @@ -1622,7 +1617,6 @@ TEST_F(Specifications, UnhandledInterCU) { google_breakpad::DW_TAG_compile_unit)); ASSERT_TRUE(root3_handler.EndAttributes()); EXPECT_CALL(reporter_, UnhandledInterCUReference(_, _)).Times(1); - EXPECT_CALL(reporter_, UnnamedFunction(_)).Times(1); DefinitionDIE(&root3_handler, google_breakpad::DW_TAG_subprogram, 0xb01fef8b380bd1a2ULL, "", 0x2618f00a1a711e53ULL, 0x4fd94b76d7c2caf5ULL);