diff --git a/src/common/memory_unittest.cc b/src/common/memory_unittest.cc index b271bc3c..8d2494c2 100644 --- a/src/common/memory_unittest.cc +++ b/src/common/memory_unittest.cc @@ -38,13 +38,13 @@ typedef testing::Test PageAllocatorTest; TEST(PageAllocatorTest, Setup) { PageAllocator allocator; - EXPECT_EQ(0, allocator.pages_allocated()); + EXPECT_EQ(0U, allocator.pages_allocated()); } TEST(PageAllocatorTest, SmallObjects) { PageAllocator allocator; - EXPECT_EQ(0, allocator.pages_allocated()); + EXPECT_EQ(0U, allocator.pages_allocated()); for (unsigned i = 1; i < 1024; ++i) { uint8_t *p = reinterpret_cast(allocator.Alloc(i)); ASSERT_FALSE(p == NULL); @@ -55,10 +55,10 @@ TEST(PageAllocatorTest, SmallObjects) { TEST(PageAllocatorTest, LargeObject) { PageAllocator allocator; - EXPECT_EQ(0, allocator.pages_allocated()); + EXPECT_EQ(0U, allocator.pages_allocated()); uint8_t *p = reinterpret_cast(allocator.Alloc(10000)); ASSERT_FALSE(p == NULL); - EXPECT_EQ(3, allocator.pages_allocated()); + EXPECT_EQ(3U, allocator.pages_allocated()); for (unsigned i = 1; i < 10; ++i) { uint8_t *p = reinterpret_cast(allocator.Alloc(i)); ASSERT_FALSE(p == NULL); @@ -79,7 +79,7 @@ TEST(WastefulVectorTest, Setup) { TEST(WastefulVectorTest, Simple) { PageAllocator allocator_; - EXPECT_EQ(0, allocator_.pages_allocated()); + EXPECT_EQ(0U, allocator_.pages_allocated()); wasteful_vector v(&allocator_); for (unsigned i = 0; i < 256; ++i) { @@ -89,7 +89,7 @@ TEST(WastefulVectorTest, Simple) { } ASSERT_FALSE(v.empty()); ASSERT_EQ(v.size(), 256u); - EXPECT_EQ(1, allocator_.pages_allocated()); + EXPECT_EQ(1U, allocator_.pages_allocated()); for (unsigned i = 0; i < 256; ++i) ASSERT_EQ(v[i], i); } @@ -97,7 +97,7 @@ TEST(WastefulVectorTest, Simple) { TEST(WastefulVectorTest, UsesPageAllocator) { PageAllocator allocator_; wasteful_vector v(&allocator_); - EXPECT_EQ(1, allocator_.pages_allocated()); + EXPECT_EQ(1U, allocator_.pages_allocated()); v.push_back(1); ASSERT_TRUE(allocator_.OwnsPointer(&v[0])); @@ -105,20 +105,20 @@ TEST(WastefulVectorTest, UsesPageAllocator) { TEST(WastefulVectorTest, AutoWastefulVector) { PageAllocator allocator_; - EXPECT_EQ(0, allocator_.pages_allocated()); + EXPECT_EQ(0U, allocator_.pages_allocated()); auto_wasteful_vector v(&allocator_); - EXPECT_EQ(0, allocator_.pages_allocated()); + EXPECT_EQ(0U, allocator_.pages_allocated()); v.push_back(1); - EXPECT_EQ(0, allocator_.pages_allocated()); + EXPECT_EQ(0U, allocator_.pages_allocated()); EXPECT_FALSE(allocator_.OwnsPointer(&v[0])); v.resize(4); - EXPECT_EQ(0, allocator_.pages_allocated()); + EXPECT_EQ(0U, allocator_.pages_allocated()); EXPECT_FALSE(allocator_.OwnsPointer(&v[0])); v.resize(10); - EXPECT_EQ(1, allocator_.pages_allocated()); + EXPECT_EQ(1U, allocator_.pages_allocated()); EXPECT_TRUE(allocator_.OwnsPointer(&v[0])); } diff --git a/src/processor/minidump_processor_unittest.cc b/src/processor/minidump_processor_unittest.cc index 609a2a68..d43c1fc9 100644 --- a/src/processor/minidump_processor_unittest.cc +++ b/src/processor/minidump_processor_unittest.cc @@ -414,7 +414,7 @@ TEST_F(MinidumpProcessorTest, TestBasicProcessing) { ASSERT_EQ(state.crash_reason(), "EXCEPTION_ACCESS_VIOLATION_WRITE"); ASSERT_EQ(state.crash_address(), 0x45U); ASSERT_EQ(state.threads()->size(), size_t(1)); - EXPECT_EQ((*state.threads())[0]->tid(), 3060); + EXPECT_EQ((*state.threads())[0]->tid(), 3060U); ASSERT_EQ(state.requesting_thread(), 0); EXPECT_EQ(1171480435U, state.time_date_stamp()); EXPECT_EQ(1171480435U, state.process_create_time());