From cf6246e2ba18426a1ab021108ecefdb8c95336a2 Mon Sep 17 00:00:00 2001 From: Marvin Scholz Date: Tue, 21 Sep 2021 03:03:04 +0200 Subject: [PATCH] Fix warnings in http_upload.cc with GCC The context arguments are of type DWORD_PTR which is actually a integer type, not a pointer, so using NULL here causes a type missmatch warning: error: passing NULL to non-pointer argument 8 [...] Change-Id: Ia52f51fd0cd33af3b139f0427dec6c59c2455d0a Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3168663 Reviewed-by: Primiano Tucci --- src/common/windows/http_upload.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common/windows/http_upload.cc b/src/common/windows/http_upload.cc index efee0d58..af6f8d9c 100644 --- a/src/common/windows/http_upload.cc +++ b/src/common/windows/http_upload.cc @@ -262,7 +262,7 @@ namespace { NULL, // password INTERNET_SERVICE_HTTP, 0, // flags - NULL)); // context + 0)); // context if (!connection.get()) { return false; } @@ -276,7 +276,7 @@ namespace { NULL, // referer NULL, // agent type http_open_flags, - NULL)); // context + 0)); // context if (!request.get()) { return false; }