breakpad/src
Leonard Grey c179ddaa58 Mac: don't call NXFindBestFatArch
`NXFindBestFatArch` is deprecated in macOS 13. We use this when an
architecture is passed in via the `-a` flag. Unfortunately, neither
of the potential replacements can help with this use case:

- `macho_for_each_slice` as suggested in a reply to FB11955188 just
enumerates slices, without the logic for inexact matches (for example,
x86_64h -> x86_64 or arm64e -> arm64).
- `macho_best_slice` as recommended by the deprecation notice only
supports finding a suitable slice to run on the local machine.

We could adapt the logic in `NXFindBestFatArch` but it gets quite
complex for some architectures. Instead, this change adapts the
`NXFindBestFatArch` polyfill used in `dump_syms_mac` for Linux, which
returns an exact match if possible, and the first slice that matches
the requested CPU type otherwise. I think this is probably Good
Enough for most cases; if not, we can try porting the x86_64 and ARM
logic and falling back to this for the rest.

Change-Id: I3b269dab7246eced768cecd994e915debd95721a
Bug: chromium:14206541420654
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4335477
Reviewed-by: Mark Mentovai <mark@chromium.org>
2023-03-27 19:07:21 +00:00
..
client Add #include <config.h> to the beginning of all cc files 2023-02-27 19:31:32 +00:00
common Mac: don't call NXFindBestFatArch 2023-03-27 19:07:21 +00:00
google_breakpad Add support for reading annotation objects in Crashpad modules 2023-01-26 20:22:33 +00:00
processor Remove extra comma in minidump_stackwalk.cc 2023-03-16 16:13:59 +00:00
third_party gyp: drop unused build system 2022-12-05 01:38:54 +00:00
tools [dump_syms/Mac] New -n MODULE arg to Mac dump_syms 2023-03-20 18:43:06 +00:00
breakpad_googletest_includes.h
config.h.in