Eric Blake 2f42c2c195 qapi: Change visit_type_FOO() to no longer return partial objects ... Returning a partial object on error is an invitation for a careless caller to leak memory. We already fixed things in an earlier patch to guarantee NULL if visit_start fails ("qapi: Guarantee NULL obj on input visitor callback error"), but that does not help the case where visit_start succeeds but some other failure happens before visit_end, such that we leak a partially constructed object outside visit_type_FOO(). As no one outside the testsuite was actually relying on these semantics, it is cleaner to just document and guarantee that ALL pointer-based visit_type_FOO() functions always leave a safe value in *obj during an input visitor (either the new object on success, or NULL if an error is encountered), so callers can now unconditionally use qapi_free_FOO() to clean up regardless of whether an error occurred. The decision is done by adding visit_is_input(), then updating the generated code to check if additional cleanup is needed based on the type of visitor in use. Note that we still leave *obj unchanged after a scalar-based visit_type_FOO(); I did not feel like auditing all uses of visit_type_Enum() to see if the callers would tolerate a specific sentinel value (not to mention having to decide whether it would be better to use 0 or ENUM__MAX as that sentinel). Backports commit 68ab47e4b4ecc1c4649362b8cc1e49794d1a6537 from qemu		2018-02-23 19:53:17 -05:00
..
crypto
default-configs
docs
fpu	fpu: silence warnings	2018-02-22 09:52:28 -05:00
hw	util: move declarations out of qemu-common.h	2018-02-22 09:25:48 -05:00
include	qapi: Change visit_type_FOO() to no longer return partial objects	2018-02-23 19:53:17 -05:00
qapi	qapi: Change visit_type_FOO() to no longer return partial objects	2018-02-23 19:53:17 -05:00
qobject	util: move declarations out of qemu-common.h	2018-02-22 09:25:48 -05:00
qom	qapi: Use strict QMP input visitor in more places	2018-02-23 15:11:35 -05:00
scripts	qapi: Change visit_type_FOO() to no longer return partial objects	2018-02-23 19:53:17 -05:00
target-arm	target-arm: Get rid of unused variable warnings	2018-02-23 12:43:09 -05:00
target-i386	target-i386: fix typo in xsetbv implementation	2018-02-23 14:15:35 -05:00
target-m68k	include/qemu/osdep.h: Don't include qapi/error.h	2018-02-21 23:08:18 -05:00
target-mips	target-mips: fix call to memset in soft reset code	2018-02-23 14:01:50 -05:00
target-sparc	target-sparc: fix register corruption in ldstub if there is no write permission	2018-02-23 14:06:38 -05:00
tcg	tcg: check for CONFIG_DEBUG_TCG instead of NDEBUG	2018-02-23 13:55:21 -05:00
util	util: align memory allocations to 2M on AArch64	2018-02-23 13:56:59 -05:00
aarch64.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
aarch64eb.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
accel.c
arm.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
armeb.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
CODING_STYLE
configure	config.status: Pass extra parameters	2018-02-22 10:12:54 -05:00
COPYING
COPYING.LIB
cpu-exec-common.c
cpu-exec.c	qemu-log: dfilter-ise exec, out_asm, op and opt_op	2018-02-22 10:06:19 -05:00
cpus.c
cputlb.c	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
exec.c	include/exec: Move cputlb exec.c defs out	2018-02-23 10:52:25 -05:00
gen_all_header.sh
glib_compat.c	glib_compat: backport hashtable iterator interfaces	2018-02-21 13:18:44 -05:00
HACKING
header_gen.py	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
ioport.c
LICENSE
m68k.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
Makefile
Makefile.objs
Makefile.target
memory.c	include/qemu/osdep.h: Don't include qapi/error.h	2018-02-21 23:08:18 -05:00
memory_mapping.c	include/qemu/osdep.h: Don't include qapi/error.h	2018-02-21 23:08:18 -05:00
mips.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
mips64.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
mips64el.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
mipsel.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
powerpc.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
qapi-schema.json
qemu-log.c	log: move qemu_log_close/qemu_log_flush from header to log.c	2018-02-22 11:13:17 -05:00
qemu-timer.c
rules.mak
softmmu_template.h
sparc.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
sparc64.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00
tcg-runtime.c
translate-all.c	translate-all: add missing fold of tb_ctx into tcg_ctx	2018-02-23 13:35:42 -05:00
translate-all.h
translate-common.c
unicorn_common.h
VERSION
vl.c	util: move declarations out of qemu-common.h	2018-02-22 09:25:48 -05:00
vl.h
x86_64.h	cputlb: move CPU_LOOP() for tlb_reset() to exec.c	2018-02-23 10:46:31 -05:00