mirror of
https://github.com/yuzu-emu/yuzu-mainline
synced 2024-11-23 00:03:49 +00:00
renderer_vulkan: Check return value of AcquireNextImage
We can get into a really bad state by ignoring this leading to device loss and using incorrect resources.
This commit is contained in:
parent
4f60818eae
commit
bcf58c8210
3 changed files with 10 additions and 5 deletions
|
@ -143,7 +143,10 @@ void RendererVulkan::SwapBuffers(const Tegra::FramebufferConfig* framebuffer) {
|
||||||
|
|
||||||
scheduler.WaitWorker();
|
scheduler.WaitWorker();
|
||||||
|
|
||||||
swapchain.AcquireNextImage();
|
while (!swapchain.AcquireNextImage()) {
|
||||||
|
swapchain.Create(layout.width, layout.height, is_srgb);
|
||||||
|
blit_screen.Recreate();
|
||||||
|
}
|
||||||
const VkSemaphore render_semaphore = blit_screen.Draw(*framebuffer, use_accelerated);
|
const VkSemaphore render_semaphore = blit_screen.Draw(*framebuffer, use_accelerated);
|
||||||
|
|
||||||
scheduler.Flush(render_semaphore);
|
scheduler.Flush(render_semaphore);
|
||||||
|
|
|
@ -82,11 +82,13 @@ void VKSwapchain::Create(u32 width, u32 height, bool srgb) {
|
||||||
resource_ticks.resize(image_count);
|
resource_ticks.resize(image_count);
|
||||||
}
|
}
|
||||||
|
|
||||||
void VKSwapchain::AcquireNextImage() {
|
bool VKSwapchain::AcquireNextImage() {
|
||||||
device.GetLogical().AcquireNextImageKHR(*swapchain, std::numeric_limits<u64>::max(),
|
const VkResult result =
|
||||||
*present_semaphores[frame_index], {}, &image_index);
|
device.GetLogical().AcquireNextImageKHR(*swapchain, std::numeric_limits<u64>::max(),
|
||||||
|
*present_semaphores[frame_index], {}, &image_index);
|
||||||
|
|
||||||
scheduler.Wait(resource_ticks[image_index]);
|
scheduler.Wait(resource_ticks[image_index]);
|
||||||
|
return result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR;
|
||||||
}
|
}
|
||||||
|
|
||||||
bool VKSwapchain::Present(VkSemaphore render_semaphore) {
|
bool VKSwapchain::Present(VkSemaphore render_semaphore) {
|
||||||
|
|
|
@ -28,7 +28,7 @@ public:
|
||||||
void Create(u32 width, u32 height, bool srgb);
|
void Create(u32 width, u32 height, bool srgb);
|
||||||
|
|
||||||
/// Acquires the next image in the swapchain, waits as needed.
|
/// Acquires the next image in the swapchain, waits as needed.
|
||||||
void AcquireNextImage();
|
bool AcquireNextImage();
|
||||||
|
|
||||||
/// Presents the rendered image to the swapchain. Returns true when the swapchains had to be
|
/// Presents the rendered image to the swapchain. Returns true when the swapchains had to be
|
||||||
/// recreated. Takes responsability for the ownership of fence.
|
/// recreated. Takes responsability for the ownership of fence.
|
||||||
|
|
Loading…
Reference in a new issue